stm32 flash read out protection rdp in a common file #81876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRASTM
added
platform: STM32
FRASTM
force-pushed
the
stm32h7_rdp_common
branch
3 times, most recently
from
837931e to
31efa57
Compare
FRASTM
force-pushed
the
stm32h7_rdp_common
branch
from
31efa57 to
900408b
Compare
zephyrbot
requested review from
GeorgeCGV,
de-nordic,
erwango,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
rghaddab
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
FRASTM
force-pushed
the
stm32h7_rdp_common
branch
from
900408b to
75fef9a
Compare
|
rebased on 0717698 |
FRASTM
force-pushed
the
stm32h7_rdp_common
branch
from
75fef9a to
354c035
Compare
|
rebase on 3d2059f |
gautierg-st
previously approved these changes
Mar 21, 2025
|
kind reminder |
niedzwiecki-dawid
requested changes
Apr 25, 2025
FRASTM
force-pushed
the
stm32h7_rdp_common
branch
from
354c035 to
7560ee1
Compare
niedzwiecki-dawid
previously approved these changes
Apr 29, 2025
gautierg-st
previously approved these changes
Apr 30, 2025
etienne-lms
reviewed
Apr 30, 2025
| regs->OPTCR |= FLASH_OPTCR_OPTLOCK; | ||
| } else if (regs->OPTCR & FLASH_OPTCR_OPTLOCK) { | ||
| regs->OPTKEYR = FLASH_OPT_KEY1; | ||
| regs->OPTKEYR = FLASH_OPT_KEY2; |
There was a problem hiding this comment.
Is this missing the H7RSX case?
#ifdef CONFIG_SOC_SERIES_STM32H7RSX
regs->OPTKEYR = FLASH_OPTKEY1;
regs->OPTKEYR = FLASH_OPTKEY2;
#elseThere was a problem hiding this comment.
yes, added in the flash_stm32.h file
FRASTM
dismissed stale reviews from gautierg-st and niedzwiecki-dawid
via
baa0e4a
FRASTM
force-pushed
the
stm32h7_rdp_common
branch
2 times, most recently
from
baa0e4a to
2412ee4
Compare
|
rebase on cd43e03 |
etienne-lms
reviewed
Apr 30, 2025
Move the flash_stm32_write_protection and flash_stm32_option_bytes_lock functions to a common file for stm32 devices including stm32h7 Signed-off-by: Francois Ramu <[email protected]>
etienne-lms
approved these changes
May 6, 2025
de-nordic
approved these changes
May 6, 2025
erwango
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the PR "Implement readout protection for STM32H7" #76640, it appears that
" Function flash_stm32_option_bytes_lock() seems to be the obvious candidate to be moved to" a common file to stm32h7 anr other stm32 series.
This common file could be the existing drivers/flash/flash_stm32_ex_op.c
The flash_stm32_option_bytes_lock() is moved there and the flash_stm32_write_protection is made external to that file